Add support for parallel read and write #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kp-mariappan-ramasamy
force-pushed
the
multi-thread-support
branch
7 times, most recently
from
cc86fd4 to
5a94ee2
Compare
kp-mariappan-ramasamy
changed the title
xv-raihaan-m
reviewed
Jan 7, 2025
| @@ -367,7 +367,7 @@ | |||
| <Optimization>MaxSpeed</Optimization> | |||
| <IntrinsicFunctions>true</IntrinsicFunctions> | |||
| <AdditionalIncludeDirectories>./;./IDE/WIN;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories> | |||
| <PreprocessorDefinitions>WOLFSSL_MIN_RSA_BITS=2048;WOLFSSL_MIN_ECC_BITS=256;HAVE_SECURE_RENEGOTIATION;WOLFSSL_DTLS_CH_FRAG;WOLFSSL_TLS13_MIDDLEBOX_COMPAT;WOLFSSL_DTLS_CH_FRAG;WOLFSSL_LIB;WOLFSSL_USER_SETTINGS;%(PreprocessorDefinitions)</PreprocessorDefinitions> | |||
There was a problem hiding this comment.
We shouldn't need to add this here just leaving it in the header file its fine
There was a problem hiding this comment.
Is this for all other definitions too, since we use header file /?
If so, I would like to leave it in this PR and do a cleanup later removing all of these defines
kp-mariappan-ramasamy
force-pushed
the
multi-thread-support
branch
from
5a94ee2 to
fb9f73c
Compare
kp-mariappan-ramasamy
requested review from
xv-raihaan-m and
expressvpn-pete-m
xv-raihaan-m
approved these changes
Jan 9, 2025
Since `he_internal_pmtud_handle_probe_ack` handles (id != conn->pmtud.probe_pending_id) we do not need to check before calling the probe pending id
if PMTUD is not completed yet.
Add atomic support for win and linux - Add windows C11 flags with experimental atomic in win - Link atomic lib for linux test
Using separate project file for now
kp-mariappan-ramasamy
force-pushed
the
multi-thread-support
branch
from
fb9f73c to
e25cf1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WolfSSL start supporting read/write in multiple threads
This PR is add support to Lightway-core to use those capability.
Related PRs:
wolfSSL/wolfssl#7796
wolfSSL/wolfssl#8284
This PR introduces a compilation macro HE_ENABLE_MULTITHREADED, which should be defined if apps want to enable multi threaded support.
If not defined, lightway core should behave exactly as similar as earlier
Motivation and Context
Make lightway core multithreaded capable
How Has This Been Tested?
Tested manually using Windows app
Types of changes
Checklist:
main